Skip to content

Conversation

@litiliu
Copy link
Contributor

@litiliu litiliu commented Aug 12, 2025

Purpose of this pull request

close #9693

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@litiliu litiliu changed the title [Feat]Update common lang3 [Feat]Update to common lang3 Aug 13, 2025
@litiliu litiliu marked this pull request as ready for review August 13, 2025 04:22
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @litiliu . Could you add a test case in ImportClassCheckTest?

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance we can remove common-lang from dependencies?

@litiliu
Copy link
Contributor Author

litiliu commented Aug 14, 2025

ImportClassCheckTest

Thanks @litiliu . Could you add a test case in ImportClassCheckTest?

Added new test case , Thanks for your brilliant idea!

@litiliu
Copy link
Contributor Author

litiliu commented Aug 14, 2025

Is there any chance we can remove common-lang from dependencies?

sure, all of the common-lang jars have been removed from the external libraries. Except some transitive dependency imported by the hive-jdbc/hive-service 3.1.3, hadoop-client 3.1.4, orc core 1.5.6, hadoop-aliyun:jar:3.0.0, spark

Would it be better to raise other PRs to update those hive/hadoop dependencies? If we directly remove the commons-lang from the hive/hadoop, it may cause errors like classNotFound?

@litiliu litiliu force-pushed the update-common-lang3 branch from 903fb92 to 17c27f5 Compare August 14, 2025 06:11
@litiliu litiliu force-pushed the update-common-lang3 branch from 17c27f5 to b0b01de Compare August 14, 2025 06:45
@Hisoka-X
Copy link
Member

Would it be better to raise other PRs to update those hive/hadoop dependencies?

+1

@Hisoka-X Hisoka-X changed the title [Feat]Update to common lang3 [Improve][Core] Update apache common to apache common lang3 Aug 15, 2025
@corgy-w corgy-w merged commit 6e5737c into apache:dev Aug 15, 2025
5 checks passed
xiaochen-zhou added a commit to TongchengOpenSource/seatunnel that referenced this pull request Aug 17, 2025
1

1

1

1

1

update doc

[Improve][Csv] support configurable CSV delimiter in file connector (apache#9660)

[Fix][Doc] Fix rest api finished-jobs doc miss `SAVEPOINT_DONE` (apache#9676)

[Fix] [connector-jdbc] prevent precision loss in Float to BigDecimal conversion (apache#9670)

[Feature][Connector-File-Hadoop]Support multi table sink feature for HdfsFile (apache#9651)

[HotFix][CI] The Some CI subtasks are not executed (apache#9684)

[Docs][Connector-Iceberg] Update Iceberg doc with support S3 Tables rest catalogs (apache#9686)

[Docs] update jdbc related document (apache#9679)

[Fix][Connector-V2] Fix misleading parameter name in DorisStreamLoad (apache#9685)

[Feature] [connector-file] Add configurable sheet_max_rows support for Excel sink connector (apache#9668)

[fix][connectors-v2] repeated commit cause task exceptions (apache#9665)

[Feature][connector-v2] Add Sensorsdata Connector Support apache#9323 (apache#9432)

[Improve][API] Optimize the enumerator API semantics and reduce lock calls at the connector level (apache#9671)

[Hotfix][Zeta] Fix custom https port configuration not working (apache#9705)

[Improve][Doc] Add SeaTunnel tools into Readme (apache#9707)

[Improve][Core] Unify the aws-sdk-v2 version to 2.31.30 (apache#9698)

[Feature][Transform-V2] Add `TRIM_SCALE` function for sql transform (apache#9700)

[Improve][Core] Update apache common to apache common lang3 (apache#9694)

Co-authored-by: litiliu <[email protected]>
HighandLight pushed a commit to HighandLight/seatunnel that referenced this pull request Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature][Update commons-lang] Update commons-lang to Update commons-lang3

3 participants