[Hotfix][Transform-V2] Fix some model return number of dimensions #9644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loupipalien
changed the title
Hisoka-X
reviewed
Jul 30, 2025
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
Thanks @loupipalien ! Could you add a test case?
Contributor
Author
Added |
Member
|
waiting test case passes. |
loupipalien
force-pushed
the
fix-embedding-model-dimension
branch
from
e18068b to
5aa8eec
Compare
Hisoka-X
approved these changes
Aug 4, 2025
corgy-w
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Fix Custom/Doubao/OpenAIModel#dimension method return number of dimensions, close #9643
Does this PR introduce any user-facing change?
No
How was this patch tested?
Check list
New License Guide