[Feature][Core] Support show cluster members information in seatunnel-cluster scripts #9502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-cluster scripts [Feature][Core] code style [Feature][Core] add test [Feature][Core] update e2e test [Feature][Core] remove e2e test [Feature][Core] remove e2e test [Feature][Core] remove e2e test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for displaying cluster members information via the seatunnel-cluster scripts.
- Introduces a new command line option (‑m/‑‑member) to show cluster members.
- Implements the showClusterMembers() logic in ServerExecuteCommand to retrieve and display member details.
- Adds a new e2e test to verify that the correct number of cluster members is returned.
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| seatunnel-core/seatunnel-starter/src/test/java/org/apache/seatunnel/core/starter/seatunnel/command/ServerExecuteCommandTest.java | Adds e2e test for validating cluster member retrieval. |
| seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ServerExecuteCommand.java | Implements the cluster members display logic and role determination. |
| seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/args/ServerCommandArgs.java | Introduces the new command line argument for showing cluster members. |
Comments suppressed due to low confidence (1)
seatunnel-core/seatunnel-starter/src/main/java/org/apache/seatunnel/core/starter/seatunnel/command/ServerExecuteCommand.java:134
- [nitpick] Consider rephrasing the error message for clarity and consistency (e.g., 'Cluster %s is not running. Please start the cluster first.').
clusterName));
Comment on lines
+145
to
+154
| System.out.printf( | ||
| "%-36s %-20s %-20s %-10s\n", "Member ID", "Address", "Role", "Version"); | ||
|
|
||
| for (Member member : members) { | ||
| System.out.printf( | ||
| "%-36s %-20s %-20s %-10s\n", | ||
| member.getUuid(), | ||
| member.getAddress(), | ||
| getRole(masterMember.getAddress(), member), | ||
| member.getVersion()); |
There was a problem hiding this comment.
Consider using the logger (e.g., log.info) instead of System.out.printf for consistent logging practices in production code.
Suggested change
| System.out.printf( | |
| "%-36s %-20s %-20s %-10s\n", "Member ID", "Address", "Role", "Version"); | |
| for (Member member : members) { | |
| System.out.printf( | |
| "%-36s %-20s %-20s %-10s\n", | |
| member.getUuid(), | |
| member.getAddress(), | |
| getRole(masterMember.getAddress(), member), | |
| member.getVersion()); | |
| log.info( | |
| String.format( | |
| "%-36s %-20s %-20s %-10s", | |
| "Member ID", "Address", "Role", "Version")); | |
| for (Member member : members) { | |
| log.info( | |
| String.format( | |
| "%-36s %-20s %-20s %-10s", | |
| member.getUuid(), | |
| member.getAddress(), | |
| getRole(masterMember.getAddress(), member), | |
| member.getVersion())); |
Hisoka-X
reviewed
Jun 26, 2025
xiaochen-zhou
force-pushed
the
support-show-nodes
branch
from
e46df88 to
e7864b4
Compare
add doc update doc
xiaochen-zhou
force-pushed
the
support-show-nodes
branch
from
6af1ae0 to
e0150ff
Compare
Hisoka-X
reviewed
Jul 28, 2025
| } | ||
|
|
||
| @Test | ||
| @DisabledOnJre(value = JRE.JAVA_11, disabledReason = "the test case only works on Java 8") |
Contributor
Author
There was a problem hiding this comment.
why it only workes on java 8?
Sorry, my mistakes. I updated the code.
Hisoka-X
reviewed
Jul 28, 2025
seatunnel-core/seatunnel-starter/src/main/bin/seatunnel-cluster.sh
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
Jul 30, 2025
seatunnel-core/seatunnel-starter/src/main/bin/seatunnel-cluster.sh
Outdated
Show resolved
Hide resolved
xiaochen-zhou
force-pushed
the
support-show-nodes
branch
from
5df3bf4 to
61b8d1e
Compare
Hisoka-X
approved these changes
Jul 31, 2025
corgy-w
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support show cluster members information in
seatunnel-clusterscriptsDoes this PR introduce any user-facing change?
Yes
How was this patch tested?
Add e2e tests
Check list
New License Guide