[Bug] [seatunnel-connector-http-base] An NPE (NullPointerException) will occur when the pageField is null #9498
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill occur when the pageField is null apache#9474
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a NullPointerException in HttpSourceReader by adding a null check for pageField before accessing it in the page map logic.
- Added
pageField != nullguard in the fallback branch to prevent NPE - No new tests were provided to cover the null-case scenario
Comments suppressed due to low confidence (2)
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:272
- There is no unit test covering the scenario where
pageFieldis null. Please add a test case that setspageFieldto null and verifies thatprocessPageMapcompletes without throwing an exception.
} else if (pageField != null && map.containsKey(pageField)) {
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/source/HttpSourceReader.java:269
- [nitpick] Consider moving the null check for
pageFieldto an earlier guard or using an early return at the top ofprocessPageMapto simplify the conditional branches and improve readability.
}
Contributor
Author
|
@Hisoka-X please review , thank you. |
Member
|
Please add test case. |
Contributor
Contributor
Author
|
Hisoka-X
approved these changes
Jun 30, 2025
corgy-w
approved these changes
Jun 30, 2025
chncaesar
pushed a commit
to chncaesar/seatunnel
that referenced
this pull request
Jun 30, 2025
…ill occur when the pageField is null (apache#9498) Co-authored-by: xinlong <[email protected]>
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
…ill occur when the pageField is null (apache#9498) Co-authored-by: xinlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close issue #9474
Does this PR introduce any user-facing change?
'No'
How was this patch tested?
not added, this code is very simple and clear. only check whether pageField is null , to avoid occur an NPE (NullPointerException)
Check list
New License Guide