[Fix][Zeta] Fix operation thread leak when master switch #9464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an operation thread leak when the master switch is triggered by updating how coordinator service calls are retried and by introducing a retryable exception. Key changes include:
- Adding a new test serializer hook and a test operation (ReturnRetryTimesOperation) to simulate retryable exceptions.
- Updating the coordinator service logic to throw a retryable exception with fixed maxRetry and retryPause values.
- Introducing a new SeaTunnelEngineRetryableException in the common module.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/operation/TestSerializerHook.java | Added a test hook for Hazelcast’s data serialization. |
| seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/operation/ReturnRetryTimesOperation.java | Introduced a test operation that throws a retryable exception. |
| seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/CoordinatorServiceTest.java | Added a test to verify retry behavior for retryable exceptions. |
| seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java | Modified retry logic by replacing property‐based configuration with fixed values. |
| seatunnel-engine/seatunnel-engine-common/src/main/java/org/apache/seatunnel/engine/common/exception/SeaTunnelEngineRetryableException.java | Added a new exception class for retryable errors. |
Comments suppressed due to low confidence (2)
seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/CoordinatorServiceTest.java:110
- The test assertion expects the retry count to reach 250, which might become fragile if the static counter is not reset or if the new hardcoded retry values affect the overall retry behavior; consider making the expected value configurable or resetting the counter before the test.
.getMessage()
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:246
- The hardcoded retry values (maxRetry = 3 and retryPause = 500) replace the previous dynamic configuration; please document the rationale behind these specific choices to ensure clarity on how they address the thread leak issue.
int maxRetry = 3;
| public class ReturnRetryTimesOperation extends Operation | ||
| implements IdentifiedDataSerializable, AllowedDuringPassiveState { | ||
|
|
||
| private static final AtomicInteger retryTimes = new AtomicInteger(0); |
There was a problem hiding this comment.
Using a static AtomicInteger for tracking retry times may lead to cross-test state contamination; consider resetting or scoping it per test to ensure independent behavior.
Suggested change
| private static final AtomicInteger retryTimes = new AtomicInteger(0); | |
| private final AtomicInteger retryTimes = new AtomicInteger(0); |
corgy-w
approved these changes
Jun 19, 2025
hailin0
approved these changes
Jun 20, 2025
chncaesar
pushed a commit
to chncaesar/seatunnel
that referenced
this pull request
Jun 30, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Fix operation thread leak when master switch, the log will print lots of
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide