[Feature][transform-v2] Data Validator Transform support #9445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Hisoka-X PTAL |
Hisoka-X
reviewed
Jun 19, 2025
...-v2/src/main/java/org/apache/seatunnel/transform/validator/DataValidatorTransformConfig.java
Outdated
Show resolved
Hide resolved
...ansforms-v2/src/main/java/org/apache/seatunnel/transform/validator/udf/DataValidatorUDF.java
Show resolved
Hide resolved
Hisoka-X
reviewed
Jun 24, 2025
Comment on lines
30
to
33
| @DisabledOnContainer( | ||
| value = {}, | ||
| type = {EngineType.SPARK, EngineType.FLINK}, | ||
| disabledReason = "Currently SPARK not support adapt") |
Comment on lines
119
to
123
| if (errorTable != null && !errorTable.isEmpty()) { | ||
| SeaTunnelRow errorRow = inputRow.copy(); | ||
| errorRow.setTableId(errorTable); | ||
| log.debug("Routing invalid data to error table: {}", errorTable); | ||
| return errorRow; |
Member
There was a problem hiding this comment.
If we have 1000 tables need to be verify. Does I also need create 1000 tables in sink for error table? Because each table has different schema. Can we design a standard structure so that the sink can use a table to store all error data?
Contributor
Author
There was a problem hiding this comment.
How about keeping only three fields, source_table_id, original_data, validation_errors.
Member
There was a problem hiding this comment.
id, table_path, original_data, validation_error, create_time.
Let original_data and validation_error store value as json format. So user can parse it easiler.
Hisoka-X
reviewed
Jul 2, 2025
...orms-v2-e2e-part-1/src/test/java/org/apache/seatunnel/e2e/transform/TestDataValidatorIT.java
Show resolved
Hide resolved
Contributor
Author
|
@Hisoka-X PTAL |
Hisoka-X
reviewed
Jul 22, 2025
seatunnel-common/src/main/java/org/apache/seatunnel/common/exception/CommonErrorCode.java
Outdated
Show resolved
Hide resolved
...sforms-v2/src/main/java/org/apache/seatunnel/transform/validator/DataValidatorTransform.java
Outdated
Show resolved
Hide resolved
...ransforms-v2/src/main/java/org/apache/seatunnel/transform/common/TransformCommonOptions.java
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
Jul 25, 2025
| | name | type | required | default value | | ||
| |-----------------|--------|----------|---------------| | ||
| | error_handle_way| enum | no | FAIL | | ||
| | error_table | string | no | | |
Hisoka-X
reviewed
Jul 28, 2025
|
|
||
| | name | type | required | default value | | ||
| |-----------------|--------|----------|---------------| | ||
| | error_handle_way| enum | no | FAIL | |
Member
There was a problem hiding this comment.
Suggested change
| | error_handle_way| enum | no | FAIL | | |
| | row_error_handle_way| enum | no | FAIL | |
Member
|
waiting test case passes. |
Hisoka-X
approved these changes
Jul 31, 2025
corgy-w
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #9413
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide