[Fix][Connector-V2] Correct typo in batch-size-per-scan option key #9434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
previously approved these changes
Jun 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR corrects a typo in the TiDB CDC connector's configuration key by removing an unintended trailing space.
- Fixes the option key from
"batch-size-per-sca "to"batch-size-per-scan". - Updates the code constant accordingly.
Comments suppressed due to low confidence (3)
seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/tidb/source/config/TiDBSourceOptions.java:65
- Please update any user documentation, example configs, and README files to reference the corrected
batch-size-per-scankey.
Options.key("batch-size-per-scan")
seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/tidb/source/config/TiDBSourceOptions.java:65
- Add or update unit tests to verify that the
batch-size-per-scanoption is parsed correctly and defaults to 1000.
Options.key("batch-size-per-scan")
seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/tidb/source/config/TiDBSourceOptions.java:65
- [nitpick] Consider adding a deprecated alias for the old
batch-size-per-scakey to maintain backward compatibility for existing user configurations.
Options.key("batch-size-per-scan")
Hisoka-X
reviewed
Jun 13, 2025
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
Could you update the doc too? I can't find this config key in the docs.
Contributor
Hisoka-X
approved these changes
Jun 16, 2025
hailin0
approved these changes
Jun 16, 2025
chncaesar
pushed a commit
to chncaesar/seatunnel
that referenced
this pull request
Jun 30, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide