[feature][connectors-v2] Support in predicate pushdown in paimon #9379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for predicate pushdown in Paimon by extending SQL predicate conversion to handle IN and NOT IN expressions, updates corresponding configuration files for end-to-end tests, and improves documentation to reflect these capabilities.
- Added new configuration files (filter6 and filter7) to test IN/NOT IN predicate pushdown.
- Extended the SQL predicate converter to handle IN expressions.
- Updated documentation in both Chinese and English regarding supported operators.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-paimon-e2e/src/test/resources/paimon_to_assert_with_filter7.conf | New end-to-end test configuration for NOT IN filtering. |
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-paimon-e2e/src/test/resources/paimon_to_assert_with_filter6.conf | New end-to-end test configuration for IN filtering. |
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-paimon-e2e/src/test/java/org/apache/seatunnel/e2e/connector/paimon/PaimonSinkCDCIT.java | Extended test cases to run the new configurations. |
| seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/source/converter/SqlToPaimonPredicateConverter.java | Added logic to handle IN expressions in SQL predicate conversion. |
| docs/zh/connector-v2/source/Paimon.md docs/en/connector-v2/source/Paimon.md |
Updated documentation with IN and NOT IN operator support. |
Comments suppressed due to low confidence (2)
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/source/converter/SqlToPaimonPredicateConverter.java:300
- [nitpick] There is a typo in the variable name 'theFiled'; consider renaming it to 'theField' for improved clarity.
Optional<DataField> theFiled =
seatunnel-connectors-v2/connector-paimon/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/source/converter/SqlToPaimonPredicateConverter.java:268
- Consider adding negative test cases to verify that handleInExpression correctly throws exceptions for empty expression lists and for cases when null values are encountered within the IN clause.
if (expressions.isEmpty()) {
Hisoka-X
approved these changes
May 29, 2025
hailin0
approved these changes
May 29, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide