[Fix][Connector-Http] fix Invalid mime type #9363
Merged
+54
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an invalid MIME type issue in the HTTP connector by adjusting how the request body is handled. Key changes include making the addBody method static, removing redundant header addition that set a content encoding, and updating the test to ensure that no manual content encoding is set.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-http/connector-http-base/src/test/java/org/apache/seatunnel/connectors/seatunnel/http/client/HttpClientProviderTest.java | Added unit tests to assert headers remain unmodified and content encoding is not set |
| seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/client/HttpClientProvider.java | Made addBody static and removed redundant and potentially problematic header modifications |
Comments suppressed due to low confidence (1)
seatunnel-connectors-v2/connector-http/connector-http-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/http/client/HttpClientProvider.java:492
- Consider adding a comment here explaining that the content encoding is intentionally not set to avoid triggering an invalid MIME type, which will help future maintainers understand the rationale behind this change.
StringEntity entity = new StringEntity(JsonUtils.toJsonString(body), ContentType.APPLICATION_JSON);
corgy-w
approved these changes
Jun 19, 2025
hailin0
approved these changes
Jun 20, 2025
chncaesar
pushed a commit
to chncaesar/seatunnel
that referenced
this pull request
Jun 30, 2025
3 tasks
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #9362
Does this PR introduce any user-facing change?
How was this patch tested?
UT added
Check list
New License Guide