[Fix][E2E] Fixed e2e test cases of Kafka did not work as expected #9359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenDing-Y
changed the title
WenDing-Y
changed the title
Hisoka-X
reviewed
May 26, 2025
...tor-v2-e2e/connector-kafka-e2e/src/test/resources/kafka/kafkasource_earliest_to_console.conf
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes Kafka error tests and updates test configurations by adding row_count validations in multiple Kafka configuration files. It also adjusts topic naming and introduces new topic management and offset commit logic in the Kafka integration test suite.
- Added row_rules configuration entries to validate row counts across several Kafka .conf files.
- Updated topic names and consumer group configuration in Kafka source tests.
- Enhanced Kafka integration tests with AdminClient topic creation and a new commitOffset method.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafka/kafkasource_timestamp_to_console.conf | Added row_rules validation configuration. |
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafka/kafkasource_specific_offsets_to_console.conf | Added row_rules validation configuration. |
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafka/kafkasource_group_offset_to_console.conf | Added row_rules and updated consumer group configuration. |
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafka/kafkasource_format_error_handle_way_skip_to_console.conf | Added row_rules with MAX_ROW to validate error handling in format tests. |
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafka/kafkasource_endTimestamp_to_console.conf | Updated topic configuration. |
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/resources/kafka/kafkasource_earliest_to_console.conf | Added row_rules validation configuration. |
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e/src/test/java/org/apache/seatunnel/e2e/connector/kafka/KafkaIT.java | Introduced AdminClient topic creation and a new commitOffset method for offset management. |
| ] | ||
| row_rules = [ | ||
| { | ||
| rule_type = MAX_ROW |
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment to explain the usage of the MAX_ROW rule with a rule_value of 0 to clarify its purpose in this error handling test configuration.
...-e2e/connector-kafka-e2e/src/test/java/org/apache/seatunnel/e2e/connector/kafka/KafkaIT.java
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
May 27, 2025
| row_rules = [ | ||
| { | ||
| rule_type = MIN_ROW | ||
| rule_value = 1 |
Member
There was a problem hiding this comment.
Suggested change
| rule_value = 1 | |
| rule_value = 100 |
set MAX_ROW and MIN_ROW as same.
Contributor
Author
There was a problem hiding this comment.
i known,all test updated
Hisoka-X
changed the title
hailin0
approved these changes
May 28, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
fix #9358
Does this PR introduce any user-facing change?
update kafka test config add row_count validate
How was this patch tested?
Check list
New License Guide