[Improve][Oracle-CDC] Fix oracle rename ddl event missing column type #9314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the missing column type issue for Oracle rename DDL events by updating the resolve method’s signature and adding a completionEvent method to complete the missing column type information.
- Updated the SchemaChangeResolver interface and AbstractSchemaChangeResolver to accept a list of CatalogTable objects instead of a SeaTunnelDataType.
- Added logic in completionEvent to complete the column type during a rename event.
- Updated the related test and Debezium deserialization to integrate the changes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AbstractSchemaChangeResolverTest.java | Added tests to verify that column type information is correctly completed during column rename events. |
| SeaTunnelRowDebeziumDeserializeSchema.java | Modified the resolve call to pass the necessary table information for column type resolution. |
| SchemaChangeResolver.java | Updated the resolve method signature to accept a List of CatalogTable instances. |
| AbstractSchemaChangeResolver.java | Refactored the resolve method and added the completionEvent method for completing column type information. |
Comments suppressed due to low confidence (2)
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/schema/AbstractSchemaChangeResolver.java:137
- Consider adding a null-check for oldColumn before calling its rename method. This will prevent potential NullPointerExceptions if the expected column is missing in the table schema.
Column oldColumn = table.getTableSchema().getColumn(changeColumnEvent.getOldColumn());
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/schema/SchemaChangeResolver.java:32
- The resolve method signature has been updated to accept a List instead of a SeaTunnelDataType. Please ensure that corresponding documentation and downstream usages are updated to reflect this change.
SchemaChangeEvent resolve(SourceRecord record, List<CatalogTable> catalogTables);
Hisoka-X
approved these changes
May 15, 2025
corgy-w
approved these changes
May 17, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide