[Fix][Connector-V2] Fix the problem that missing options configuration when building ClickHouse Nodes #9277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s ineffective because the options configuration is not passed when building ClickHouse Nodes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a configuration issue with ClickHouse connectors by ensuring that the options configuration is correctly passed when building ClickHouse Nodes.
- Replace usage of a hard-coded null with the actual configuration value for CLICKHOUSE_CONFIG in node initialization.
- Update both the main util class and the file sink factory to use the provided CLICKHOUSE_CONFIG value.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/util/ClickhouseUtil.java | Replaced null with config.get(ClickhouseBaseOptions.CLICKHOUSE_CONFIG) for node creation. |
| seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/file/ClickhouseFileSinkFactory.java | Updated sink factory to use readonlyConfig.get(CLICKHOUSE_CONFIG) instead of null. |
| config.get(ClickhouseBaseOptions.DATABASE), | ||
| config.get(ClickhouseBaseOptions.SERVER_TIME_ZONE), | ||
| config.get(ClickhouseBaseOptions.USERNAME), | ||
| config.get(ClickhouseBaseOptions.PASSWORD), |
There was a problem hiding this comment.
[nitpick] Consider adding an inline comment explaining the role and expected structure of CLICKHOUSE_CONFIG during node initialization to aid future maintainability.
Suggested change
| config.get(ClickhouseBaseOptions.PASSWORD), | |
| config.get(ClickhouseBaseOptions.PASSWORD), | |
| // CLICKHOUSE_CONFIG is a map of configuration options for the ClickHouse client. | |
| // Keys and values represent specific settings supported by the ClickHouse client library. |
| readonlyConfig.get(USERNAME), | ||
| readonlyConfig.get(PASSWORD), | ||
| null); | ||
| readonlyConfig.get(CLICKHOUSE_CONFIG)); |
There was a problem hiding this comment.
[nitpick] Consider adding a comment to describe the purpose of passing CLICKHOUSE_CONFIG in the sink setup, providing clarity for contributors reviewing configuration handling.
Hisoka-X
approved these changes
May 7, 2025
hailin0
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem that the clickhouse.config becomes ineffective because the options configuration is not passed when building ClickHouse Nodes
Purpose of this pull request
Fix the problem that the clickhouse.config becomes ineffective because the options configuration is not passed when building ClickHouse Nodes.
In the existing implementation, the
clickhouse.configconfiguration actually does not take effect when the data source is ClickHouse. This is because the corresponding configuration is not passed when building the ClickHouse Nodes used to connect to ClickHouse.Does this PR introduce any user-facing change?
No.
How was this patch tested?
This is a rather obvious problem with the connector client configuration. You can simply follow the existing test cases for testing. There's no need to write a separate test case for these options configuration.
Check list
New License Guide
release-note.