[improve] sentry options #9261
Merged
[improve] sentry options #9261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the Sentry connector’s options usage by replacing the legacy Config with the newer ReadonlyConfig and SentrySinkOptions, and updates related factory and test files accordingly.
- Refactored SentrySinkWriter and SentrySink to use ReadonlyConfig and SentrySinkOptions.
- Updated SentrySinkFactory to reference SentrySinkOptions.
- Adjusted test expectations in ConnectorOptionCheckTest.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-sentry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/sink/SentrySinkWriter.java | Replaced legacy Config with ReadonlyConfig and updated option getters. |
| seatunnel-connectors-v2/connector-sentry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/sink/SentrySinkFactory.java | Updated to use SentrySinkOptions constants and added sink creation method. |
| seatunnel-connectors-v2/connector-sentry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/sink/SentrySink.java | Removed the prepare method and injected CatalogTable along with ReadonlyConfig. |
| seatunnel-connectors-v2/connector-sentry/src/main/java/org/apache/seatunnel/connectors/seatunnel/sentry/config/SentrySinkOptions.java | Changed option types from String to their respective types (Boolean, Integer, Long). |
| seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java | Removed SentrySinkOptions from whitelist. |
Comments suppressed due to low confidence (1)
seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ConnectorOptionCheckTest.java:199
- The removal of 'SentrySinkOptions' from the whitelist may result in configuration validation issues during testing; please confirm that this omission is intentional and does not impact test coverage of the Sentry connector.
whiteList.add("SentrySinkOptions");
corgy-w
previously approved these changes
May 11, 2025
hailin0
previously approved these changes
May 11, 2025
hailin0
approved these changes
May 11, 2025
Hisoka-X
approved these changes
May 12, 2025
dybyte
pushed a commit
to dybyte/seatunnel
that referenced
this pull request
Jul 23, 2025
Co-authored-by: hailin0 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.