[fix][connector-mango] fix split with avgSize zero error #9255
+51
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a division by zero issue in the MongoDB connector's split logic when the average document size (AvgSize) is zero.
- Adds tests to cover scenarios where AvgSize is zero with and without documents.
- Updates the SamplingSplitStrategy to handle avgSize of zero without throwing an exception.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-mongodb/src/test/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/split/SamplingSplitStrategyTest.java | Adds tests for zero avgSize scenarios |
| seatunnel-connectors-v2/connector-mongodb/src/main/java/org/apache/seatunnel/connectors/seatunnel/mongodb/source/split/SamplingSplitStrategy.java | Adds condition to handle avgSize <= 0 and prevent division by zero |
| long avgSize = numAndAvgSize.getRight(); | ||
|
|
||
| // Handle the case when avgSize is 0 to prevent division by zero | ||
| if (avgSize <= 0) { |
There was a problem hiding this comment.
Consider revising the condition to explicitly check for avgSize == 0 if negative values for avgSize are not expected. If negative avgSize could occur, it may be indicative of invalid data and should be handled appropriately.
Suggested change
| if (avgSize <= 0) { | |
| if (avgSize == 0) { |
Hisoka-X
changed the title
Hisoka-X
approved these changes
Apr 30, 2025
hailin0
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix split with AvgSize zero
close #9245
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.