[improve] qdrant options #9235
Merged
[improve] qdrant options #9235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Qdrant connector configuration by refactoring the option classes used in both the source and sink implementations. Key changes include replacing the generic QdrantConfig with more specialized classes (QdrantSourceOptions, QdrantSinkOptions, and QdrantBaseOptions) and updating all corresponding references, along with adjusting the connector option rule definitions.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-qdrant/src/main/java/org/apache/seatunnel/connectors/seatunnel/qdrant/source/QdrantSourceFactory.java | Updated references from QdrantConfig to QdrantSourceOptions for consistency. |
| seatunnel-connectors-v2/connector-qdrant/src/main/java/org/apache/seatunnel/connectors/seatunnel/qdrant/source/QdrantSource.java | Changed connector identity reference from QdrantConfig to QdrantBaseOptions. |
| seatunnel-connectors-v2/connector-qdrant/src/main/java/org/apache/seatunnel/connectors/seatunnel/qdrant/sink/QdrantSinkFactory.java | Replaced QdrantConfig with QdrantSinkOptions and updated option rule definition to include COLLECTION_NAME. |
| seatunnel-connectors-v2/connector-qdrant/src/main/java/org/apache/seatunnel/connectors/seatunnel/qdrant/sink/QdrantSink.java | Updated connector identity reference from QdrantConfig to QdrantBaseOptions. |
| QdrantSourceOptions.java, QdrantSinkOptions.java, QdrantParameters.java, QdrantBaseOptions.java | Introduced new option classes and updated key references to support the improved option management. |
| seatunnel-ci-tools ConnectorOptionCheckTest.java | Removed QdrantSinkOptions and QdrantSourceOptions from the whitelist in accordance with the new configuration scheme. |
Hisoka-X
approved these changes
Apr 28, 2025
corgy-w
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.