[Fix][CI] Release file resources in testcase #9232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which leads to slow subsequent file parsing
Hisoka-X
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the file resource leakage issue by adding cleanup methods to reset static state in test classes, thus ensuring that subsequent file parsing is not adversely affected by residual test state.
- Introduced an @afterall cleanup method in SerialVersionUIDCheckerTest.java to clear static collections.
- Introduced an @afterall cleanup method in ImportClassCheckTest.java to clear the importsMap.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/SerialVersionUIDCheckerTest.java | Added a cleanup method to reset static collections and avoid resource retention between tests. |
| seatunnel-ci-tools/src/test/java/org/apache/seatunnel/api/ImportClassCheckTest.java | Added a cleanup method to reset the importsMap to ensure a clean state for testing. |
Hisoka-X
approved these changes
Apr 25, 2025
hailin0
changed the title
hailin0
approved these changes
Apr 25, 2025
jia17
pushed a commit
to jia17/seatunnel
that referenced
this pull request
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the problem of not releasing file resources, which leads to slow subsequent file parsing
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.