[Feature][Connector-V2] Make some sink parameters optional for DataHub #9229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ataHub implementation
Hisoka-X
previously approved these changes
Apr 25, 2025
Member
|
Thanks @jia17 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes sink parameters optional for the DataHub connector by moving the TIMEOUT and RETRY_TIMES options from required to optional and assigning them default values.
- Updated DataHubSinkFactory option rules to mark TIMEOUT and RETRY_TIMES as optional
- Set default values for TIMEOUT (3000) and RETRY_TIMES (3) in DataHubSinkOptions
- Adjusted both English and Chinese documentation to reflect the new optional nature and default values
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| seatunnel-connectors-v2/connector-datahub/sink/DataHubSinkFactory.java | Adjusted option rule for DataHub connector to mark TIMEOUT and RETRY_TIMES as optional |
| seatunnel-connectors-v2/connector-datahub/config/DataHubSinkOptions.java | Updated default values for TIMEOUT and RETRY_TIMES |
| docs/zh/connector-v2/sink/Datahub.md | Updated documentation to reflect optional TIMEOUT and RETRY_TIMES with default values |
| docs/en/connector-v2/sink/Datahub.md | Updated documentation to reflect optional TIMEOUT and RETRY_TIMES with default values |
Contributor
|
Please try ci again |
jia17
force-pushed
the
Align_params_DataHub_impl
branch
from
8825fa3 to
f57f577
Compare
jia17
force-pushed
the
Align_params_DataHub_impl
branch
from
66f4ed6 to
f57f577
Compare
added 2 commits
April 26, 2025 14:48
…ataHub implementation
…Align_params_DataHub_impl
corgy-w
approved these changes
Apr 27, 2025
hailin0
approved these changes
Apr 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #9226
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.