[Feature][Connector-V2] Datahub support multi-table sink #9212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 22, 2025 13:04
… into support_multitable_sink_datahub
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for multi-table sinks for the Datahub connector by updating the implementation classes and tests.
- Added a new end-to-end test method (testDatahubMulti) to validate multi-table sink functionality.
- Updated DataHubWriter and DataHubSink to implement the multi-table sink interfaces.
- Modified DataHubSinkFactory to include the optional multi-table sink replica option.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| seatunnel-e2e/seatunnel-connector-v2-e2e/connector-datahub-e2e/src/test/java/org/apache/seatunnel/e2e/connector/datahub/DatahubIT.java | Added multi-table sink E2E test method. |
| seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/sink/DataHubWriter.java | Updated to implement SupportMultiTableSinkWriter. |
| seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/sink/DataHubSinkFactory.java | Introduced optional multi-table sink replica configuration. |
| seatunnel-connectors-v2/connector-datahub/src/main/java/org/apache/seatunnel/connectors/seatunnel/datahub/sink/DataHubSink.java | Modified to implement SupportMultiTableSink and return a DataHubWriter. |
Files not reviewed (1)
- seatunnel-e2e/seatunnel-connector-v2-e2e/connector-datahub-e2e/src/test/resources/fakesource_to_multi_datahub.conf: Language not supported
Member
|
Please upload a screenshot of the Datahub page |
Contributor
Author
|
|
Hisoka-X
approved these changes
Apr 23, 2025
hailin0
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subtask of #5652
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
new e2e test using my Alibaba Cloud account locally.
Check list
New License Guide
release-note.