[Fix][Zeta] Fix double-checked locking without volatile in HdfsStorage #9200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 使用 volatile 关键字确保 HdfsStorage 实例的线程安全 - 优化 HdfsStorage 中的日志输出
Contributor
|
Hi @maozhen520 , Please open ci according to the instructions |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a thread-safety issue with double-checked locking in the HDFS checkpoint storage by adding the volatile keyword and improves the logging format for enhanced clarity. Additionally, it refines the method signature in the FileConfiguration class to remove an unused parameter, ensuring consistency with its usage in HdfsStorage.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| HdfsFileStorageInstance.java | Added the volatile keyword to HDFS_STORAGE for safe double-checked locking. |
| FileConfiguration.java | Removed the unused parameter in getConfiguration(), aligning with its updated usage. |
| HdfsStorage.java | Updated the logging message for clarity and adjusted configuration retrieval accordingly. |
Contributor
Author
DONE. |
Hisoka-X
changed the title
Hisoka-X
approved these changes
Apr 22, 2025
hailin0
approved these changes
Apr 22, 2025
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request addresses two issues identified in the HDFS checkpoint storage code:
Does this PR introduce any user-facing change?
No
How was this patch tested?
This patch primarily involves minor changes to logging and the addition of the volatile keyword to a field. Given the nature of these changes, no new test cases were added. The existing test suite covers the functionality of the HdfsStorage class, and these changes do not introduce new logic that requires additional testing.
The changes made are:
Logging Improvements: Enhanced log messages for better clarity and debugging.
Volatile Keyword: Added the volatile keyword to ensure visibility of changes to the fs field across threads.
These modifications are unlikely to affect the existing behavior, and thus, the existing test cases are sufficient to validate the changes.
Check list
New License Guide
release-note.