[Fix][Serialize] prevent scientific notation for decimal numbers in JSON output #9186
Conversation
|
copy PR from #9126, it can't pass ci test ,so i copy the PR |
There was a problem hiding this comment.
Pull Request Overview
This pull request resolves bug 8949 by adjusting JSON serialization behavior for BigDecimal values and enhancing test coverage.
- Added a new unit test (testSerializationWithNumber) to verify that BigDecimal values are serialized as plain numbers.
- Configured the underlying Jackson mapper to write BigDecimal values in plain format.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| seatunnel-formats/seatunnel-format-json/src/test/java/org/apache/seatunnel/format/json/JsonRowDataSerDeSchemaTest.java | Added a new test to check proper serialization of numeric types with BigDecimal specialization. |
| seatunnel-formats/seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/JsonSerializationSchema.java | Configured the Jackson mapper to write BigDecimal as plain text to support the fix. |
Comments suppressed due to low confidence (1)
seatunnel-formats/seatunnel-format-json/src/test/java/org/apache/seatunnel/format/json/JsonRowDataSerDeSchemaTest.java:690
- [nitpick] Consider using StandardCharsets.UTF_8 instead of Charset.forName("UTF-8") for consistency with the rest of the code.
JsonSerializationSchema jsonSerializationSchema = new JsonSerializationSchema(schema, Charset.forName("UTF-8"));
| private final RowToJsonConverters.RowToJsonConverter runtimeConverter; | ||
|
|
||
| { | ||
| mapper.configure(JsonGenerator.Feature.WRITE_BIGDECIMAL_AS_PLAIN, true); |
There was a problem hiding this comment.
[nitpick] Consider moving the mapper configuration from the instance initializer block into the constructor to ensure the initialization order is explicit.
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
seatunnel-formats/seatunnel-format-json/src/test/java/org/apache/seatunnel/format/json/JsonRowDataSerDeSchemaTest.java:691
- [nitpick] Consider adding additional test cases for BigDecimal values (e.g., with trailing zeros or varying precision) to further validate the serialization behavior.
Object[] fields = new Object[] {1, "1001015", BigDecimal.valueOf(80.00)};
corgy-w
changed the title
[bugfix] add test case [bugfix] code format [improve] test annotation [improve] remove annotation [improve] modify character set
misi1987107
force-pushed
the
bugfix-8949
branch
from
1703c64 to
1c74345
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the serialization behavior for BigDecimal values by preventing scientific notation in JSON outputs. It adds a new test case to validate that a decimal value is output in plain format and configures the JSON mapper accordingly.
- Added a test case for decimal number serialization.
- Configured the ObjectMapper to use plain BigDecimal formatting.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| seatunnel-format-json/src/test/java/org/apache/seatunnel/format/json/JsonRowDataSerDeSchemaTest.java | Added a test case to verify that a BigDecimal value is not output in scientific notation. |
| seatunnel-format-json/src/main/java/org/apache/seatunnel/format/json/JsonSerializationSchema.java | Updated the ObjectMapper configuration to write BigDecimal values as plain numbers. |
Comments suppressed due to low confidence (1)
seatunnel-formats/seatunnel-format-json/src/test/java/org/apache/seatunnel/format/json/JsonRowDataSerDeSchemaTest.java:691
- Consider adding additional test cases with a range of BigDecimal values (including very small and very large numbers) to further ensure that scientific notation is consistently prevented.
Object[] fields = new Object[] {1, "1001015", BigDecimal.valueOf(80.00)};
|
@misi1987107 CI Try again and try again, feels successful soon |
|
|
Thanks. |
…SON output (apache#9186) Co-authored-by: misi <gientech.com>
3 participants
Purpose of this pull request
subtask of #8949
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.