[Feature][Transform] Support define sink column type #9114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
force-pushed
the
dev-transform-sinktype
branch
from
4a7ab15 to
a08a605
Compare
hailin0
force-pushed
the
dev-transform-sinktype
branch
from
a08a605 to
dfad0e1
Compare
hailin0
force-pushed
the
dev-transform-sinktype
branch
2 times, most recently
from
225ec7b to
ea5708a
Compare
3 tasks
Contributor
There was a problem hiding this comment.
Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/iris/IrisCreateTableSqlBuilder.java:113
- Consider using a check that also validates for blank values (e.g. StringUtils.isNotBlank(column.getSinkType())) instead of only a null check to avoid unintended behavior when an empty string is provided.
if (column.getSinkType() != null) {
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/mysql/MysqlCreateTableSqlBuilder.java:182
- [nitpick] Consider specifying an explicit access modifier (e.g. private) for the buildColumnIdentifySql method to ensure consistency and clarity with similar methods in other catalog builder classes.
String buildColumnIdentifySql(
Member
Author
|
PTAL |
Contributor
There was a problem hiding this comment.
Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
seatunnel-connectors-v2/connector-jdbc/catalog/sqlserver/SqlServerCreateTableSqlBuilder.java:199
- [nitpick] Consider using a check for a non-blank sink type (e.g., StringUtils.isNotBlank(column.getSinkType())) instead of only a null check to avoid using empty strings as column types.
if (column.getSinkType() != null) {
seatunnel-connectors-v2/connector-jdbc/catalog/psql/PostgresCreateTableSqlBuilder.java:127
- The access modifier for buildColumnSql was changed from private to package-private; if this change is not intentional, consider reverting to private to preserve encapsulation.
String buildColumnSql(Column column) {
seatunnel-connectors-v2/connector-clickhouse/util/ClickhouseCatalogUtil.java:35
- [nitpick] Consider validating that column.getSinkType() is not only non-null but also non-empty to prevent empty string values from being used as the column type.
if (column.getSinkType() != null) {
Hisoka-X
reviewed
Apr 15, 2025
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
|
|
||
| public class DefineSinkTypeTransformTest { |
hailin0
force-pushed
the
dev-transform-sinktype
branch
from
ea5708a to
e891ecf
Compare
hailin0
force-pushed
the
dev-transform-sinktype
branch
from
e891ecf to
155dd67
Compare
Hisoka-X
approved these changes
Apr 21, 2025
corgy-w
approved these changes
Apr 22, 2025
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Transform] Support define sink column type
Does this PR introduce any user-facing change?
add new transform
How was this patch tested?
Check list
New License Guide
release-note.