Skip to content

Conversation

@prclin
Copy link
Contributor

@prclin prclin commented Mar 19, 2025

Purpose of this pull request

add helm test case

Does this PR introduce any user-facing change?

no

How was this patch tested?

change field "on" in check-helm-chart.yml to "workflow_dispatch", and manually run workflow.

Check list

@github-actions github-actions bot added the CI&CD label Mar 19, 2025
@prclin
Copy link
Contributor Author

prclin commented Mar 19, 2025

all done for helm action, but need to push a new changes in deploy/kubernetes/seatunnel to trigger workflow to test if it can be triggered.
this workflow has been tested manually by switch field "on" to "workflow_dispatch". for further test, need to push new commits which edit chart files.

@liunaijie
Copy link
Member

thanks! @prclin LGTM

liunaijie
liunaijie previously approved these changes Mar 19, 2025
@Hisoka-X Hisoka-X added the don't merge There needs to be a specific reason in the PR, and it cannot be merged for the time being. label Mar 19, 2025
@prclin prclin force-pushed the 8982-add-helm-test-case branch from 4f0032c to 00c09c6 Compare March 24, 2025 03:02
@prclin
Copy link
Contributor Author

prclin commented Mar 24, 2025

kudu job failed, i rerunned it. but it should not be affect by these commits

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prclin

@hailin0 hailin0 merged commit d3a9ff7 into apache:dev Mar 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved CI&CD don't merge There needs to be a specific reason in the PR, and it cannot be merged for the time being. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants