Skip to content

Conversation

@FrommyMind
Copy link
Contributor

Purpose of this pull request

Fix #8929

Does this PR introduce any user-facing change?

No

How was this patch tested?

Check list

Tested on my local windows pc.
After enable fileAppender in log4j2_client.properties. client log have been created.

@github-actions github-actions bot added the core SeaTunnel core module label Mar 8, 2025
@Hisoka-X
Copy link
Member

Could you help verify it? @hawk9821

hailin0
hailin0 previously approved these changes Mar 10, 2025
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrommyMind
Copy link
Contributor Author

Update the logic of get filename. May fix this #8226 (comment)

@Hisoka-X Hisoka-X merged commit a3d7784 into apache:dev Mar 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved core SeaTunnel core module reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Command] Run seatunnel on windows with fileAppender enabled, no log file been created

3 participants