[Improve][Connector-V2] Random pick the starrocks fe address which can be connected #8898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe address which can be connected
Hisoka-X
previously approved these changes
Mar 6, 2025
Hisoka-X
reviewed
Mar 6, 2025
| private QueryPlan getQueryPlan(String querySQL, String table) { | ||
|
|
||
| List<String> nodeUrls = sourceConfig.getNodeUrls(); | ||
| Collections.shuffle(nodeUrls); |
Member
There was a problem hiding this comment.
Let's add some comment on here. Make sure other devs know why we need shuffle.
Contributor
Author
There was a problem hiding this comment.
Let's add some comment on here. Make sure other devs know why we need shuffle.
Done.
hailin0
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Make sure the random and ha be supported at the same time. Random pick the address which can be connected.
referring to the implementation in the Doris connector： https://github.com/apache/seatunnel/pull/8311#pullrequestreview-2507771700_
Does this PR introduce any user-facing change?
no
How was this patch tested?
exists test
Check list
New License Guide
release-note.