[Feature][elasticsearch-connector] support elasticsearch sql source #8895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Mar 6, 2025
| ``` | ||
|
|
||
| 案例六 : sql 方式查询 | ||
| notes: sql does not support map and array types |
| public static final Option<String> SEARCH_TYPE = | ||
| Options.key("search_type") | ||
| .stringType() | ||
| .defaultValue("dsl") |
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.seatunnel.connectors.seatunnel.elasticsearch.dto.source; |
Member
There was a problem hiding this comment.
Suggested change
| package org.apache.seatunnel.connectors.seatunnel.elasticsearch.dto.source; | |
| package org.apache.seatunnel.connectors.seatunnel.elasticsearch.client; |
Comment on lines
84
to
86
| cursorSearchResult(seaTunnelRowType, sourceIndexInfo, output); | ||
| } else { | ||
| scrollSearchResult(seaTunnelRowType, sourceIndexInfo, output); |
Member
There was a problem hiding this comment.
what's different between cursorSearchResult and scrollSearchResult? Can we merge it?
…' into feature-elasticsearch-sql-search
3 tasks
Hisoka-X
reviewed
Mar 12, 2025
| Deque<ElasticsearchSourceSplit> splits = new LinkedList<>(); | ||
| boolean noMoreSplit; | ||
|
|
||
| private final String SQL_TYPE = "sql"; |
Hisoka-X
approved these changes
Mar 12, 2025
hailin0
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #8894
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.