[Feature][Connector-V2] Suppor Time type in paimon connector #8880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corgy-w
reviewed
Mar 2, 2025
Contributor
corgy-w
left a comment
corgy-w
left a comment
There was a problem hiding this comment.
TKS , There seems to be only a slight problem
Comment on lines
269
to
273
| return DateTimeUtils.toInternal( | ||
| org.apache.seatunnel.common.utils.DateUtils.parse(strValue)); | ||
| case TIME_WITHOUT_TIME_ZONE: | ||
| return DateTimeUtils.toInternal( | ||
| org.apache.seatunnel.common.utils.TimeUtils.parse(strValue)); |
Contributor
There was a problem hiding this comment.
org.apache.seatunnel.common.utils. These two package prefixes do not seem to be required
Contributor
Author
There was a problem hiding this comment.
org.apache.seatunnel.common.utils.These two package prefixes do not seem to be required
done.
Comment on lines
300
to
301
| } else if (expression instanceof TimeValue) { | ||
| return ((TimeValue) expression).getValue(); |
Contributor
There was a problem hiding this comment.
expression instanceof TimeValue repeated
Contributor
Author
There was a problem hiding this comment.
expression instanceof TimeValuerepeated
done.
hawk9821
reviewed
Mar 3, 2025
Contributor
Author
Done. |
xiaochen-zhou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Add support for Time type in paimon connector
Does this PR introduce any user-facing change?
yes
How was this patch tested?
Add new tests
Check list
New License Guide
release-note.