Skip to content

[improve] improve TaskLocation/TaskLocationGroup info #8862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liunaijie merged 7 commits into from
Mar 6, 2025
Merged

[improve] improve TaskLocation/TaskLocationGroup info #8862

liunaijie merged 7 commits into from
Mar 6, 2025

Conversation

@liunaijie
Copy link
Member

@liunaijie liunaijie commented Feb 27, 2025

Purpose of this pull request

close ##8861

Does this PR introduce any user-facing change?

How was this patch tested?

use existing tests

Check list

@github-actions github-actions bot added the Zeta label Feb 27, 2025
@Hisoka-X
Copy link
Member

Hisoka-X commented Feb 28, 2025

Please add UT.

@Hisoka-X Hisoka-X linked an issue Feb 28, 2025 that may be closed by this pull request
[Improve][PhysicalPlan] improve the TaskLocation information. #8861
Closed
3 tasks
liunaijie
liunaijie commented Mar 3, 2025
View reviewed changes
...ine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalVertex.java
taskGroup.getTaskGroupName(),
subTaskGroupIndex + 1,
parallelism,
taskGroupLocation);
Copy link
Member Author

@liunaijie liunaijie Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always print taskGroupLocation info

Hisoka-X
Hisoka-X approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @liunaijie

@liunaijie liunaijie merged commit 67c8b79 into apache:dev Mar 6, 2025
6 checks passed
@liunaijie liunaijie deleted the improve/task_location branch March 10, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees

No one assigned

Labels

approved reviewed Zeta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Improve][PhysicalPlan] improve the TaskLocation information.

3 participants

@liunaijie @Hisoka-X @hailin0