[Feature][Transform-v2] Add support for Zhipu AI in Embedding and LLM module #8790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liunaijie
reviewed
Feb 24, 2025
| List<List<Float>> vectors = batchProcess(fields, singleVectorizedInputNumber); | ||
| for (List<Float> vector : vectors) { | ||
| result.add(BufferUtils.toByteBuffer(vector.toArray(new Float[0]))); | ||
| List<List<Double>> vectors = batchProcess(fields, singleVectorizedInputNumber); |
Member
There was a problem hiding this comment.
Overall LGTM. Only one question is why change this type?
Contributor
Author
There was a problem hiding this comment.
Overall LGTM. Only one question is why change this type?
In some models, such as the official SDK provided by Zhipu, the type returned after embedding is Double. Therefore, I think our current use of Float may not meet the requirements
liunaijie
approved these changes
Feb 25, 2025
Member
liunaijie
left a comment
liunaijie
left a comment
There was a problem hiding this comment.
LGTM, thanks @xiaochen-zhou !
hailin0
approved these changes
Feb 25, 2025
Contributor
|
@xiaochen-zhou ，good job. |
xiaochen-zhou
added a commit
to TongchengOpenSource/seatunnel
that referenced
this pull request
Jul 28, 2025
… and LLM module (apache#8790)" This reverts commit 51ffc5a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Zhipu AI has launched Vector mode: Embedding-2 and Embedding-3, and Chat model: GLM series. Some well-known AI applications, such as Vanna, have already integrated Zhipu models.
Does this PR introduce any user-facing change?
yes
How was this patch tested?
add new tests
Check list
New License Guide
release-note.