[Feature][Connector-v2] Support multi starrocks source #8789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaochen-zhou
changed the title
hailin0
reviewed
Feb 24, 2025
|
|
||
| @DisabledOnContainer( | ||
| value = {}, | ||
| type = {EngineType.SPARK, EngineType.FLINK}, |
Member
There was a problem hiding this comment.
Suggested change
| type = {EngineType.SPARK, EngineType.FLINK}, |
Currently supported
Hisoka-X
reviewed
Feb 24, 2025
| if (null == host) { | ||
| throw new StarRocksConnectorException( | ||
| CommonErrorCodeDeprecated.ILLEGAL_ARGUMENT, | ||
| CommonErrorCode.ILLEGAL_ARGUMENT, |
Member
There was a problem hiding this comment.
Please do not directly use common error code, we should create it in
hailin0
reviewed
Feb 24, 2025
| sink { | ||
| Assert { | ||
| rules { | ||
| table-names = ["e2e_table_source", "e2e_table_source_3"] |
Member
Contributor
Author
Hisoka-X
reviewed
Mar 3, 2025
| public class StarRocksQueryPlanReadClient { | ||
| private RetryUtils.RetryMaterial retryMaterial; | ||
| private SourceConfig sourceConfig; | ||
| private SeaTunnelRowType seaTunnelRowType; |
Member
There was a problem hiding this comment.
Suggested change
| private SeaTunnelRowType seaTunnelRowType; |
| QUEST_QUERY_PLAN_FAILED("STARROCKS-06", "Request query Plan failed"), | ||
| READER_ARROW_DATA_FAILED("STARROCKS-07", "Read Arrow data failed"); | ||
| READER_ARROW_DATA_FAILED("STARROCKS-07", "Read Arrow data failed"), | ||
| HOST_IS_NULL("STARROCKS-07", "Read Arrow data failed"); |
Member
There was a problem hiding this comment.
Suggested change
| HOST_IS_NULL("STARROCKS-07", "Read Arrow data failed"); | |
| HOST_IS_NULL("STARROCKS-08", "Read Arrow data failed"); |
Hisoka-X
approved these changes
Mar 3, 2025
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
LGTM if ci passes. Thanks @xiaochen-zhou
hailin0
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Support multi starrocks source
Does this PR introduce any user-facing change?
Yes
How was this patch tested?
Add new tests
Check list
New License Guide
release-note.