Skip to content

Conversation

@uniding
Copy link
Contributor

@uniding uniding commented Feb 14, 2025

Purpose of this pull request

close #8460 #8070

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@uniding uniding changed the title [Fix][zeta][Connector-paimon] Fix paimon run from checkpoint error #8460 #8070 [Fix][zeta][Connector-paimon] Fix paimon run from checkpoint bug Feb 14, 2025
@Hisoka-X
Copy link
Member

@uniding
Copy link
Contributor Author

uniding commented Feb 17, 2025

Please follow the link to open github action on your fork repositoy. https://github.com/apache/seatunnel/pull/8730/checks?check_run_id=37219576667

I have checked and passed

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PaimonSaveModeHandler too. I think we can skip setLoadTable in PaimonSaveModeHandler if paimonTable field value is not null.

@Hisoka-X
Copy link
Member

Could you add a test case too?

@uniding
Copy link
Contributor Author

uniding commented Feb 19, 2025

Please update PaimonSaveModeHandler too. I think we can skip setLoadTable in PaimonSaveModeHandler if paimonTable field value is not null.

It has been modified. If it is RECREATE_SCHEMA mode, it needs to be set

@Hisoka-X
Copy link
Member

Could you add a test case too?

@uniding

@uniding
Copy link
Contributor Author

uniding commented Feb 19, 2025

Could you add a test case too?

@uniding

This modification will no longer report null pointer errors when running from checkpoint, but the Paimon jar package code will report error " File deletion conflicts detected! Give up committing.
err.txt

so test cases cannot be added. It is estimated that a new version of Paimon jar will solve this problem
@Hisoka-X

@Hisoka-X
Copy link
Member

cc @hawk9821 as well.

Copy link
Contributor

@hawk9821 hawk9821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does version 2.3.9 reliably reproduce this issue ?

@uniding
Copy link
Contributor Author

uniding commented Mar 1, 2025

does version 2.3.9 reliably reproduce this issue ?

@hawk9821 2.3.9 and master branch having the same issue

@hawk9821
Copy link
Contributor

hawk9821 commented Mar 3, 2025

does version 2.3.9 reliably reproduce this issue ?

@hawk9821 2.3.9 and master branch having the same issue

refer to MysqlCDCIT.testMultiTableWithRestore e2e case , could you add a test case ?

@uniding
Copy link
Contributor Author

uniding commented Mar 4, 2025

Could you add a test case too?

@uniding

This modification will no longer report null pointer errors when running from checkpoint, but the Paimon jar package code will report error " File deletion conflicts detected! Give up committing. err.txt

so test cases cannot be added. It is estimated that a new version of Paimon jar will solve this problem @Hisoka-X

@hawk9821

@dailai dailai changed the title [Fix][zeta][Connector-paimon] Fix paimon run from checkpoint bug [Fix][zeta][Connector-paimon] Fix NullPointerException when restore from checkpoint in paimon task May 19, 2025
@dailai
Copy link
Contributor

dailai commented May 19, 2025

@uniding Thank you very much for fix this error, I look at the repair is no problem. cc @Hisoka-X @hawk9821

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a test case to reproduce the bug. @uniding cc @dailai
Please refer

to verify paimon sink with restore.

@hawk9821
Copy link
Contributor

hawk9821 commented Aug 1, 2025

Could you add a test case too?

@uniding

This modification will no longer report null pointer errors when running from checkpoint, but the Paimon jar package code will report error " File deletion conflicts detected! Give up committing. err.txt
so test cases cannot be added. It is estimated that a new version of Paimon jar will solve this problem @Hisoka-X

@hawk9821

@uniding Paimon version upgrade to 1.1.1 #8074 , please add test case

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.

@github-actions github-actions bot added the stale label Nov 30, 2025
@github-actions
Copy link

github-actions bot commented Dec 7, 2025

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Dec 7, 2025
@uniding
Copy link
Contributor Author

uniding commented Dec 7, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] mysql cdc to paimon ,from checkpoint restart error [Bug] [Connector][Paimon] setLoadTable too late when restoreJob

4 participants