[Improve] restruct connector common options #8634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
liunaijie
changed the title
Member
Author
|
update to
|
Member
|
cc @hailin0 |
liunaijie
force-pushed
the
improve/env_options
branch
2 times, most recently
from
541e429 to
1afc808
Compare
3 tasks
liunaijie
commented
Feb 11, 2025
|
|
||
| public static OptionRule getEnvOptionRules() { | ||
| @AutoService(Factory.class) | ||
| public class EnvOptionRule implements Factory { |
Member
Author
There was a problem hiding this comment.
Make this class implement Factory. Then we can also use SPI to get the env config parameters.
Member
There was a problem hiding this comment.
The env is only one, why we need SPI?
Member
Author
There was a problem hiding this comment.
If use Factory. we can use this code to verify parameter.
OptionRule optionRule = ServiceLoader.load(Factory.class, classLoader).filter("xxxxx").getEnvOptionRules();
ConfigValidator.of(context.getOptions()).validate(optionRule);
If not implement Factory. the behavior is like this.
OptionRule optionRule;
if( is connector ){
optionRule = ServiceLoader.load(Factory.class, classLoader).filter("xxxxx").getEnvOptionRules();
} else if ( is env ) {
optionRule = EnvOptionRule.getEnvOptionRules();
}
ConfigValidator.of(context.getOptions()).validate(optionRule);
I am both Ok. but looks implement Factory looks have a unified style.
liunaijie
force-pushed
the
improve/env_options
branch
from
1afc808 to
34137a0
Compare
Hisoka-X
approved these changes
Feb 13, 2025
hailin0
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
subtask of #8576
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.