[Improve][Jdbc] Improve catalog connection cache #8626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
commented
Feb 8, 2025
| } | ||
| } | ||
|
|
||
| public List<String> listSynonym(String databaseName) |
| private final String SELECT_COLUMNS = | ||
| "SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_SCHEMA = '%s' AND TABLE_NAME ='%s' ORDER BY ordinal_position ASC"; | ||
|
|
||
| protected final Map<String, Connection> connectionMap; |
|
|
||
| @Override | ||
| public CatalogTable getTable(String sqlQuery) throws SQLException { | ||
| try (Connection connection = getConnection(defaultUrl)) { |
Hisoka-X
approved these changes
Feb 14, 2025
wuchunfu
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
[Jdbc] Improve catalog connection cache
Does this PR introduce any user-facing change?
No
How was this patch tested?
Check list
New License Guide
release-note.