Skip to content

Conversation

@lm-ylj
Copy link
Contributor

@lm-ylj lm-ylj commented Jan 24, 2025

Purpose of this pull request

close #8586

Does this PR introduce any user-facing change?

How was this patch tested?

I can simulate and reproduce the scenario where the problem occurred
The testing steps are as follows:
step1: Start the task to synchronize data from MySQL CDC to Redis
step2: After the task synchronization is completed, execute the MySQL command "flush binary logs;" to create a new binlog file
step3: Wait to receive the binlog heartbeat event and the next checkpoint events
step4: Pause Task
step5: Execute the MySQL command “purge binary logs before 'xxx“ to delete the previous binlog file
step6: Restore Task
Error will occur before modification
After modification, the task can be restored normally

Check list

@hailin0
Copy link
Member

hailin0 commented Jan 24, 2025

Thanks! Please add test cases

@github-actions github-actions bot added the e2e label Jan 25, 2025
@Hisoka-X
Copy link
Member

Hisoka-X commented Feb 5, 2025

waiting test case passes.

@hailin0
Copy link
Member

hailin0 commented Feb 6, 2025

please retry ci

splitState.asIncrementalSplitState().setStartupOffset(position);
emitElement(element, output);
} else if (isDataChangeRecord(element)) {
} else if (isDataChangeRecord(element) || isHeartbeatRecord(element)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need #8569 too? @hailin0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@hailin0 hailin0 merged commit 087087e into apache:dev Feb 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [MySQL-CDC] Restore task failed due to the deletion of binlog

3 participants