-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Fix][MySQL-CDC]fix recovery task failure caused by binlog deletion #8587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Please add test cases |
Member
|
waiting test case passes. |
Member
|
please retry ci |
Hisoka-X
approved these changes
Feb 8, 2025
Hisoka-X
reviewed
Feb 8, 2025
| splitState.asIncrementalSplitState().setStartupOffset(position); | ||
| emitElement(element, output); | ||
| } else if (isDataChangeRecord(element)) { | ||
| } else if (isDataChangeRecord(element) || isHeartbeatRecord(element)) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
hailin0
approved these changes
Feb 8, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
close #8586
Does this PR introduce any user-facing change?
How was this patch tested?
I can simulate and reproduce the scenario where the problem occurred
The testing steps are as follows:
step1: Start the task to synchronize data from MySQL CDC to Redis
step2: After the task synchronization is completed, execute the MySQL command "flush binary logs;" to create a new binlog file
step3: Wait to receive the binlog heartbeat event and the next checkpoint events
step4: Pause Task
step5: Execute the MySQL command “purge binary logs before 'xxx“ to delete the previous binlog file
step6: Restore Task
Error will occur before modification
After modification, the task can be restored normally
Check list
New License Guide
release-note.