[Fix][connector-elasticsearch] support elasticsearch nest type && spark with Array<map> #8492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corgy-w
reviewed
Jan 10, 2025
Contributor
corgy-w
left a comment
corgy-w
left a comment
There was a problem hiding this comment.
This looks like a good contribution，There is a small ut that needs to be added
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java
Outdated
Show resolved
Hide resolved
3 tasks
Contributor
|
LGTM,Please @Hisoka-X review it |
Hisoka-X
reviewed
Jan 15, 2025
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/SeaTunnelRow.java
Outdated
Show resolved
Hide resolved
…rk with Array<map>
…rk with Array<map>
Contributor
Author
|
@Hisoka-X PTAL |
Hisoka-X
reviewed
Jan 17, 2025
Comment on lines
+120
to
+130
| if (((ArrayType<?, ?>) dataType).getElementType() instanceof MapType) { | ||
| Object arrayMap = | ||
| Array.newInstance(ArrayBasedMapData.class, ((Map[]) field).length); | ||
| for (int i = 0; i < ((Map[]) field).length; i++) { | ||
| Map<?, ?> value = (Map<?, ?>) ((Map[]) field)[i]; | ||
| MapType<?, ?> type = | ||
| (MapType<?, ?>) ((ArrayType<?, ?>) dataType).getElementType(); | ||
| Array.set(arrayMap, i, convertMap(value, type)); | ||
| } | ||
| return ArrayData.toArrayData(arrayMap); | ||
| } |
Member
|
Overall LGTM. |
Hisoka-X
approved these changes
Jan 21, 2025
hailin0
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support elasticsearch nest type && spark with Array
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.