Skip to content

[Fix][Flink] Fix NPE when get null row from upstream transform #8469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hailin0 merged 5 commits into from
Jan 8, 2025
Merged

[Fix][Flink] Fix NPE when get null row from upstream transform #8469

hailin0 merged 5 commits into from
Jan 8, 2025

Conversation

@litiliu
Copy link
Contributor

@litiliu litiliu commented Jan 7, 2025 •
edited
Loading

Purpose of this pull request

This close #8468
This PR adds a filter operator to filter the null rows generated by the transform plugins. It's easier than adding the null check in every transform plugin.

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added core SeaTunnel core module e2e labels Jan 7, 2025
Hisoka-X
Hisoka-X approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @litiliu

@Hisoka-X Hisoka-X changed the title [Bug] [Seatunnel flink starter]fix null row causes NPE [Fix][Flink] Fix NPE when get null row from upstream transform Jan 7, 2025
Hisoka-X
Hisoka-X requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test case in

seatunnel/seatunnel-e2e/seatunnel-transforms-v2-e2e/seatunnel-transforms-v2-e2e-part-1/src/test/java/org/apache/seatunnel/e2e/transform/TestFilterRowKindIT.java

Line 28 in adb656e

public class TestFilterRowKindIT extends TestSuiteBase {

Hisoka-X
Hisoka-X approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes.

@hailin0 hailin0 merged commit 2827876 into apache:dev Jan 8, 2025
4 checks passed
@litiliu litiliu deleted the fix-8468 branch January 9, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees

No one assigned

Labels

approved core SeaTunnel core module e2e reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [Seatunnel flink starter] null row causes NPE

3 participants

@litiliu @hailin0 @Hisoka-X