[Feature][connector-elasticsearch] elasticsearch support nested type #8462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
|
Please resolve the conflict |
# Conflicts: # seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/ArrayType.java
…_es_nest_type # Conflicts: # seatunnel-api/src/main/java/org/apache/seatunnel/api/table/type/ArrayType.java
…e' into feature_es_nest_type
Hisoka-X
reviewed
Jan 7, 2025
| public static final ArrayType<LocalTimeType[], LocalTimeType> OFFSET_DATE_TIME_ARRAY_TYPE = | ||
| new ArrayType(LocalTimeType[].class, LocalTimeType.OFFSET_DATE_TIME_TYPE); | ||
|
|
||
| public static final ArrayType<MapType[], MapType> MAP_ARRAY_TYPE = |
Member
There was a problem hiding this comment.
I think the map array should be the same as the decimal type. We cannot define a universal static type, but it should be defined dynamically.
| builder.dataType(rowType); | ||
| break; | ||
| case EsType.NESTED: | ||
| builder.dataType(ArrayType.MAP_ARRAY_TYPE); |
Member
There was a problem hiding this comment.
Suggested change
| builder.dataType(ArrayType.MAP_ARRAY_TYPE); | |
| builder.dataType(new ArrayType<>(Map[].class, new MapType<>(BasicType.STRING_TYPE, BasicType.STRING_TYPE))); |
Hisoka-X
approved these changes
Jan 7, 2025
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
LGTM if ci passes. cc @zhangshenghang
hailin0
approved these changes
Jan 7, 2025
Hisoka-X
added a commit
to Hisoka-X/seatunnel-fork
that referenced
this pull request
Jan 9, 2025
…ed type (apache#8462)" This reverts commit eaa15e4.
Hisoka-X
added a commit
that referenced
this pull request
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elasticsearch support nested type
#8454
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.