[fix][connector-v2][connector-assert] Optimize Assert Sink verification method #8356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Hisoka-X PTAL. |
Hisoka-X
approved these changes
Dec 20, 2024
Member
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
LGTM if ci passes. Thanks @zhangshenghang !
hailin0
approved these changes
Dec 20, 2024
| Thread.sleep(WAIT_SINK_WRITER_COMPLETE_TIME); | ||
| } catch (InterruptedException e) { | ||
| throw new RuntimeException(e); | ||
| } |
Member
There was a problem hiding this comment.
LGTM, but we should implement committer to final count check
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
When there are multiple AssertSinkWriters, some Sinks will run to completion first and enter the close method. You need to let it wait for other Sinks to complete, otherwise it will make wrong judgments.
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.