[Fix][Flink] Resolve streaming source high CPU usage #8354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
reviewed
Dec 20, 2024
Comment on lines
65
to
71
| private final ScheduledExecutorService scheduledExecutor = | ||
| Executors.newSingleThreadScheduledExecutor( | ||
| r -> { | ||
| Thread thread = new Thread(r, "source-reader-scheduler"); | ||
| thread.setDaemon(true); | ||
| return thread; | ||
| }); |
Member
There was a problem hiding this comment.
could you share some details about why we should introduce the ScheduledExecutorService in reader?
Member
Author
There was a problem hiding this comment.
When there is no data, we should return InputStatus.NOTHIND_AVAILABLE When returning the NOTHIND_AVAILABLE state, the isAvailable() method will be executed. IsAvailable returns a future, where the longer the blocking time, the lower the Busy value.
3 tasks
hailin0
reviewed
Dec 21, 2024
...nk-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkSourceReader.java
Outdated
Show resolved
Hide resolved
Member
TyrantLucifer
left a comment
TyrantLucifer
left a comment
There was a problem hiding this comment.
BTW, could you please offer some test results about this optimize?
...nk-common/src/main/java/org/apache/seatunnel/translation/flink/source/FlinkSourceReader.java
Outdated
Show resolved
Hide resolved
Hisoka-X
changed the title
Hisoka-X
previously approved these changes
Dec 23, 2024
zhangshenghang
dismissed stale reviews from Hisoka-X and hailin0
via
eae9995
hailin0
approved these changes
Dec 24, 2024
Hisoka-X
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
modify after
Verify Source Kafka
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.