Skip to content

[Feature][ClickhouseFile] Support add publicKey to identity #8351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hailin0 merged 2 commits into from
Dec 21, 2024
Merged

[Feature][ClickhouseFile] Support add publicKey to identity #8351

hailin0 merged 2 commits into from
Dec 21, 2024

Conversation

@caicancai
Copy link
Member

@caicancai caicancai commented Dec 20, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@caicancai
Copy link
Member Author

caicancai commented Dec 20, 2024

cc @Hisoka-X

@caicancai caicancai changed the title [Feature][ClickhouseFile]Support add publicKey to identity [Feature][ClickhouseFile] Support add publicKey to identity Dec 20, 2024
@caicancai caicancai requested a review from Hisoka-X December 21, 2024 00:50
Hisoka-X
Hisoka-X reviewed Dec 21, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update

seatunnel/seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/file/ClickhouseFileSinkFactory.java

Line 51 in eb0bf89

.optional(
too.

@caicancai
Copy link
Member Author

caicancai commented Dec 21, 2024

Please update

seatunnel/seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/sink/file/ClickhouseFileSinkFactory.java

Line 51 in eb0bf89

.optional(

too.

done

@caicancai caicancai requested a review from Hisoka-X December 21, 2024 03:14
Hisoka-X
Hisoka-X previously approved these changes Dec 21, 2024
View reviewed changes
@wuchunfu
Copy link
Member

wuchunfu commented Dec 21, 2024

@caicancai The document seems to have not been updated. Please update the document. Thanks

@caicancai
Copy link
Member Author

caicancai commented Dec 21, 2024

@caicancai The document seems to have not been updated. Please update the document. Thanks

done, There are many vague and wrong places in the ClickhouseFile documentation. I guess I will submit a PR to improve it later.

@caicancai caicancai requested a review from Hisoka-X December 21, 2024 09:57
@Hisoka-X
Copy link
Member

Hisoka-X commented Dec 21, 2024

@caicancai The document seems to have not been updated. Please update the document. Thanks

done, There are many vague and wrong places in the ClickhouseFile documentation. I guess I will submit a PR to improve it later.

Thanks @caicancai

@hailin0 hailin0 merged commit 287b8c8 into apache:dev Dec 21, 2024
5 checks passed
@caicancai caicancai deleted the key branch December 22, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees

No one assigned

Labels

approved clickhouse connectors-v2 document reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@caicancai @wuchunfu @Hisoka-X @hailin0