[Feature][Connector-V2] Support the jdbc connector for highgo db #8282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hgo-supprot # Conflicts: # seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/highgo/HighGoCatalog.java # seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/highgo/HighGoCatalogFactory.java # seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/highgo/HighGoDialectFactory.java # seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-7/src/test/java/org/apache/seatunnel/connectors/seatunnel/jdbc/JdbcHighGoIT.java
Hisoka-X
reviewed
Dec 13, 2024
...c/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/highgo/HighGoCatalog.java
Outdated
Show resolved
Hide resolved
Hisoka-X
reviewed
Dec 16, 2024
Comment on lines
307
to
308
| // set connection | ||
| ((HighGoCatalog) catalog).setConnection(jdbcUrl, connection); |
Member
There was a problem hiding this comment.
why not let HighGoCatalog create new jdbc connection by itself?
Contributor
Author
There was a problem hiding this comment.
why not let
HighGoCatalogcreate new jdbc connection by itself?
I looked at other JDBC test cases that implemented setConnection, such as iris opengauss, So I imitated and implemented it. And if this setconnection is not implemented, it will cause the test code to have a 'No suitable driver found for' issue
Hisoka-X
approved these changes
Dec 16, 2024
Hisoka-X
changed the title
hailin0
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
New jdbc connector for highgo db.
Does this PR introduce any user-facing change?
yes
How was this patch tested?
testcontainers
Check list
New License Guide
release-note.