-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Feature][Connectors-v2]Paimon version upgrade to 1.1.1 #8074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0292734 to
853960f
Compare
...ctor-paimon-e2e/src/test/java/org/apache/seatunnel/e2e/connector/paimon/PaimonSinkCDCIT.java
Outdated
Show resolved
Hide resolved
...nel-connector-v2-e2e/connector-paimon-e2e/src/test/resources/fake_cdc_sink_paimon_case9.conf
Show resolved
Hide resolved
...ctor-paimon-e2e/src/test/java/org/apache/seatunnel/e2e/connector/paimon/PaimonSinkCDCIT.java
Outdated
Show resolved
Hide resolved
5fa7e4e to
690c856
Compare
|
I think we should keep the default behavior of seatunnel when writing to paimon which is that we still used fixed buckets and the default number of buckets is 1, and we should also mark dynamic buckets as experimental properties. |
060fd30 to
9c5377f
Compare
...on/src/main/java/org/apache/seatunnel/connectors/seatunnel/paimon/catalog/PaimonCatalog.java
Outdated
Show resolved
Hide resolved
| .forEach(field -> builder.column(field.name(), field.type(), field.description())); | ||
| builder.options(schema.options()); | ||
| Map<String, String> options = new HashMap<>(schema.options()); | ||
| options.remove(CoreOptions.PATH.key()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment of why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paimon interface has changed in the new version. it will throw exception when not remove
java.lang.UnsupportedOperationException: The current catalog FileSystemCatalog does not support specifying the table path when creating a table.
at org.apache.paimon.catalog.AbstractCatalog.validateCustomTablePath(AbstractCatalog.java:582)
at org.apache.paimon.catalog.AbstractCatalog.createTable(AbstractCatalog.java:285)
at org.apache.paimon.catalog.DelegateCatalog.createTable(DelegateCatalog.java:106)
| this.newTableWrite(); | ||
| BucketMode bucketMode = this.paimonFileStoretable.bucketMode(); | ||
| this.dynamicBucket = | ||
| BucketMode.DYNAMIC == bucketMode || BucketMode.GLOBAL_DYNAMIC == bucketMode; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why remove GLOBAL_DYNAMIC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The paimon interface has changed in the new version
public enum BucketMode {
HASH_FIXED,
HASH_DYNAMIC,
CROSS_PARTITION,
BUCKET_UNAWARE;
...
}
...nel-connector-v2-e2e/connector-paimon-e2e/src/test/resources/fake_cdc_sink_paimon_case9.conf
Outdated
Show resolved
Hide resolved
a6c0a80 to
c284d30
Compare
c284d30 to
466ae0a
Compare
466ae0a to
97dbe2a
Compare
dbd51bd to
85a4f65
Compare
87644b3 to
ac8ae4f
Compare
ac8ae4f to
d32128d
Compare
Purpose of this pull request
The current dependency is set to
0.7.0-incubating, which is an incubating release of Apache Paimon, It is necessary to upgrade to the stable version 1.1.1.Does this PR introduce any user-facing change?
How was this patch tested?
PaimonSinkDynamicBucketIT#testParallelismWrite
Check list
New License Guide
release-note.