Skip to content

[Fix][Zeta] Remove duplicate LIFECYCLE_WRITER_CLOSE events #7984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wuchunfu merged 4 commits into from
Nov 19, 2024
Merged

[Fix][Zeta] Remove duplicate LIFECYCLE_WRITER_CLOSE events #7984

wuchunfu merged 4 commits into from
Nov 19, 2024

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Nov 5, 2024 •
edited
Loading

Purpose of this pull request

Remove duplicate LIFECYCLE_WRITER_CLOSE events, it already send by

seatunnel/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/task/flow/SinkFlowLifeCycle.java

Line 178 in 5089d8a

writerContext.getEventListener().onEvent(new WriterCloseEvent());

Does this PR introduce any user-facing change?

no

How was this patch tested?

add new test

Check list

@Hisoka-X
Copy link
Member Author

Hisoka-X commented Nov 5, 2024

cc @zhangshenghang @hailin0

@github-actions github-actions bot added api and removed Zeta labels Nov 5, 2024
hailin0
hailin0 previously approved these changes Nov 14, 2024
View reviewed changes
@hailin0
Copy link
Member

hailin0 commented Nov 14, 2024

LGTM

waiting for ci passed

@wuchunfu wuchunfu merged commit 2d19388 into apache:dev Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hailin0 hailin0 hailin0 approved these changes

@wuchunfu wuchunfu wuchunfu approved these changes

Assignees

No one assigned

Labels

api approved e2e reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hisoka-X @hailin0 @wuchunfu