[Feature][Doris] Support multi-table source read #7895
Conversation
| - [x] [schema projection](../../concept/connector-v2-features.md) | ||
| - [x] [parallelism](../../concept/connector-v2-features.md) | ||
| - [x] [support user-defined split](../../concept/connector-v2-features.md) | ||
| - [x] [support multiple table read](../../concept/connector-v2-features.md) |
There was a problem hiding this comment.
update cn docs
done.
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
LGTM except one minior problem. Thanks @happyboy1024 !
| DorisSourceTable dorisSourceTable = | ||
| tables.get(TablePath.of(partition.getDatabase(), partition.getTable())); | ||
| if (dorisSourceTable == null) { | ||
| return; |
There was a problem hiding this comment.
I think we should throw exception.
There was a problem hiding this comment.
I think we should throw exception.
Do we need to terminate directly here? Or do we add the warn log output, what do you think?
There was a problem hiding this comment.
An exception should be thrown because if there is no bug with the connector, it should never be null
There was a problem hiding this comment.
An exception should be thrown because if there is no bug with the connector, it should never be null
Ok, I see what you mean. I'll adjust. thx
Hisoka-X
left a comment
Hisoka-X
left a comment
There was a problem hiding this comment.
LGTM if ci passes. Thanks @happyboy1024 !
|
waiting for ci passed |
3 participants
Purpose of this pull request
Support Doris multi read and close #5731
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.