Skip to content

Conversation

@corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Oct 16, 2024

Purpose of this pull request

Fix worker node metrics acquisition

Does this PR introduce any user-facing change?

How was this patch tested?

add test case

Check list

@corgy-w corgy-w marked this pull request as ready for review October 23, 2024 10:42
@corgy-w
Copy link
Contributor Author

corgy-w commented Oct 23, 2024

PTAL @Hisoka-X

Hisoka-X
Hisoka-X previously approved these changes Oct 23, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passses. Thanks @corgy-w !

hailin0
hailin0 previously approved these changes Oct 23, 2024
@hailin0 hailin0 dismissed their stale review October 23, 2024 12:06

waiting for ci passed

@Hisoka-X Hisoka-X added this to the 2.3.9 milestone Oct 26, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @corgy-w !

@hailin0 hailin0 merged commit 50113e7 into apache:dev Oct 27, 2024
@corgy-w corgy-w deleted the fix-telemetry branch November 26, 2024 07:17
LeonYoah pushed a commit to LeonYoah/seatunnel that referenced this pull request May 8, 2025
liunaijie pushed a commit to liunaijie/seatunnel that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants