Skip to content

Conversation

@Hisoka-X
Copy link
Member

Purpose of this pull request

Before this PR, the test case of format_error_handle_way not work right. It produce json format record and parse it by json format. It will never face format error situtation. This PR make sure the format_error_handle_way work right.

Does this PR introduce any user-facing change?

no

How was this patch tested?

update test case.

Check list

@Hisoka-X
Copy link
Member Author

cc @Carl-Zhou-CN

private Throwable error;

public boolean isEmpty() {
public boolean isEmpty() throws Exception {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Spark will finished even read data failed when read first row.

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@hailin0 hailin0 merged commit 63c7b4e into apache:dev Oct 17, 2024
@Hisoka-X Hisoka-X deleted the fix-kafka-error-handleway branch October 18, 2024 12:28
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [Kafka Source] format_error_handle_way = skip is Not effective

3 participants