Skip to content

Conversation

@CosmosNi
Copy link
Contributor

@CosmosNi CosmosNi commented Oct 8, 2024

#7759

handler string and date type convert
image
image

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the api label Oct 8, 2024
@Hisoka-X
Copy link
Member

Hisoka-X commented Oct 8, 2024

This patch cannot cover all situations. We should ensure from the source side that no abnormal data is sent to the downstream.

@github-actions github-actions bot removed the api label Oct 9, 2024
@CosmosNi
Copy link
Contributor Author

CosmosNi commented Oct 9, 2024

@Hisoka-X When converting the type, it is not converted to String

@CosmosNi CosmosNi changed the title [Fix][seatunnel-api] Fix when schema difference from data type. [Fix][Connector-V2] Fix local file source catalog transform ex Oct 9, 2024
@CosmosNi CosmosNi changed the title [Fix][Connector-V2] Fix local file source catalog transform ex [Fix][Connector-V2] FFix When reading Excel data, string and date type conversion errors Oct 9, 2024
@Hisoka-X Hisoka-X changed the title [Fix][Connector-V2] FFix When reading Excel data, string and date type conversion errors [Fix][Connector-V2] Fix When reading Excel data, string and date type conversion errors Oct 9, 2024
@CosmosNi CosmosNi requested a review from Hisoka-X October 9, 2024 06:41
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @CosmosNi

@liugddx liugddx merged commit 749b2fe into apache:dev Oct 9, 2024
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 11, 2024
CosmosNi added a commit to CosmosNi/seatunnel that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants