-
Notifications
You must be signed in to change notification settings - Fork 2.2k
[Fix][Connector-V2] Fix When reading Excel data, string and date type conversion errors #7796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This patch cannot cover all situations. We should ensure from the source side that no abnormal data is sent to the downstream. |
…nto fix_schema_dataType_different
Contributor
Author
|
@Hisoka-X When converting the type, it is not converted to String |
Hisoka-X
reviewed
Oct 9, 2024
...ain/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/ExcelReadStrategy.java
Show resolved
Hide resolved
… conversion errors
… conversion errors
… conversion errors
… conversion errors
…ema_dataType_different
Hisoka-X
approved these changes
Oct 9, 2024
Member
Hisoka-X
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @CosmosNi
liugddx
approved these changes
Oct 9, 2024
3 tasks
fcb-xiaobo
pushed a commit
to fcb-xiaobo/seatunnel
that referenced
this pull request
Oct 11, 2024
… conversion errors (apache#7796)
CosmosNi
added a commit
to CosmosNi/seatunnel
that referenced
this pull request
Oct 15, 2024
… conversion errors (apache#7796)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7759
handler string and date type convert


Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.