Skip to content

[Fix][Zeta] If Zeta not a TCP discovery, it cannot find other members #7757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liunaijie merged 2 commits into from
Sep 28, 2024
Merged

[Fix][Zeta] If Zeta not a TCP discovery, it cannot find other members #7757

liunaijie merged 2 commits into from
Sep 28, 2024

Conversation

@loustler
Copy link
Contributor

@loustler loustler commented Sep 27, 2024

Purpose of this pull request

Fix a bug in SeaTunnelNodeContext, please see #7750.

It resolved #7754

Does this PR introduce any user-facing change?

NO

How was this patch tested?

Packaged the sea tunnel-starter.jar, place it it in a docker image

Check list

@github-actions github-actions bot added the Zeta label Sep 27, 2024
@loustler
Copy link
Contributor Author

loustler commented Sep 27, 2024

@Hisoka-X @liunaijie
I'll add a test case for it later

Hisoka-X
Hisoka-X reviewed Sep 27, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loustler ! Waiting test case.

@loustler loustler changed the title Fix a bug that returns nothing [Fix][Zeta] Zeta cannot find other members not in a TCP discovery Sep 27, 2024
@loustler loustler changed the title [Fix][Zeta] Zeta cannot find other members not in a TCP discovery [Fix][Zeta] If Zeta not a TCP discovery, it cannot find other members Sep 27, 2024
@github-actions github-actions bot added the e2e label Sep 27, 2024
@loustler
Copy link
Contributor Author

loustler commented Sep 27, 2024

@Hisoka-X @liunaijie
A new test case is passed.
Please review this

Hisoka-X
Hisoka-X approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @loustler!

@liunaijie liunaijie merged commit dff3ef4 into apache:dev Sep 28, 2024
@loustler loustler deleted the fix/7754 branch September 28, 2024 01:49
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 11, 2024
@loustler @fcb-xiaobo
[Fix][Zeta] If Zeta not a TCP discovery, it cannot find other members (…
0acb567 
…apache#7757)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liunaijie liunaijie liunaijie approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees

No one assigned

Labels

approved e2e reviewed Zeta

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] [Zeta] Zeta Server cannot find other members via Kubernetes Discovery

3 participants

@loustler @liunaijie @Hisoka-X