Skip to content

Conversation

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X commented Sep 26, 2024

Purpose of this pull request

Carry from #7720, it will override document change from PR. So let ci can not check with document change which devs update.

Passed ci which should not passed: #7732
Other PR can not passed because already merged document change: https://github.com/apache/seatunnel/actions/runs/11044812623/job/30681410547?pr=7748

Does this PR introduce any user-facing change?

no

How was this patch tested?

exist test.

Check list

@github-actions github-actions bot added the CI&CD label Sep 26, 2024
Copy link
Contributor

@dailai dailai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

| username | string | no | - |
| password | string | no | - |
| name | type | required | default value |
|-------------------------|---------|----------|----------------------------------------------------------------|
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update doc to trigger it.

Copy link
Member

@Carl-Zhou-CN Carl-Zhou-CN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liunaijie liunaijie merged commit fffa300 into apache:dev Sep 26, 2024
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants