Skip to content

Conversation

@corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Sep 20, 2024

Purpose of this pull request

Fix known directory create and delete ignore issues:

When creating or deleting, should consider the role of ignore key

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@corgy-w corgy-w marked this pull request as ready for review September 20, 2024 04:13
@Hisoka-X
Copy link
Member

Could you add some test case? Thanks.

@corgy-w
Copy link
Contributor Author

corgy-w commented Sep 20, 2024

Could you add some test case? Thanks.

get

@github-actions github-actions bot added the e2e label Sep 22, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @corgy-w

@hailin0 hailin0 merged commit e2fb679 into apache:dev Sep 23, 2024
PeppaPage pushed a commit to PeppaPage/seatunnel that referenced this pull request Sep 23, 2024
PeppaPage pushed a commit to PeppaPage/seatunnel that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants