Skip to content

[Fix][Connector-V2] Fixed iceberg sink can not handle uppercase fields #7660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hisoka-X merged 1 commit into from
Sep 23, 2024
Merged

[Fix][Connector-V2] Fixed iceberg sink can not handle uppercase fields #7660

Hisoka-X merged 1 commit into from
Sep 23, 2024

Conversation

@sunxiaojian
Copy link
Contributor

@sunxiaojian sunxiaojian commented Sep 13, 2024

Purpose of this pull request

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Hisoka-X
Hisoka-X requested changes Sep 14, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case?

@sunxiaojian
Copy link
Contributor Author

sunxiaojian commented Sep 14, 2024

Could you add a test case?

This is useless code, existing case can cover it

Hisoka-X
Hisoka-X previously approved these changes Sep 15, 2024
View reviewed changes
@hailin0
Copy link
Member

hailin0 commented Sep 18, 2024

Is there any need to modify here?
https://github.com/apache/seatunnel/pull/7656/files#diff-75806c45c1b7d159a39a4442309885784ee116d510a2f147b347ab26db03e2b4R113

@sunxiaojian
Copy link
Contributor Author

sunxiaojian commented Sep 20, 2024

Is there any need to modify here? https://github.com/apache/seatunnel/pull/7656/files#diff-75806c45c1b7d159a39a4442309885784ee116d510a2f147b347ab26db03e2b4R113

@hailin0 Don't need it

@hailin0
Copy link
Member

hailin0 commented Sep 20, 2024

Is there any need to modify here? https://github.com/apache/seatunnel/pull/7656/files#diff-75806c45c1b7d159a39a4442309885784ee116d510a2f147b347ab26db03e2b4R113

@hailin0 Don't need it

@sunxiaojian

Why is it needed here?

seatunnel/seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/data/RowConverter.java

Line 221 in 4a2e272

? schema.caseInsensitiveField(fieldName)

@sunxiaojian
Copy link
Contributor Author

sunxiaojian commented Sep 20, 2024

Is there any need to modify here? https://github.com/apache/seatunnel/pull/7656/files#diff-75806c45c1b7d159a39a4442309885784ee116d510a2f147b347ab26db03e2b4R113

@hailin0 Don't need it

@sunxiaojian

Why is it needed here?

seatunnel/seatunnel-connectors-v2/connector-iceberg/src/main/java/org/apache/seatunnel/connectors/seatunnel/iceberg/data/RowConverter.java

Line 221 in 4a2e272

? schema.caseInsensitiveField(fieldName)

In order to be consistent with the case_Sensitive configuration, I have already added it, but the primary keys can be overridden through configuration.

@sunxiaojian sunxiaojian force-pushed the fixed-iceberg branch 3 times, most recently from b23c71d to 0ba0395 Compare September 20, 2024 09:50
@github-actions github-actions bot added the e2e label Sep 20, 2024
@Hisoka-X Hisoka-X changed the title [Bug][connector-iceberg]fixed iceberg sink [Fix][Connector-V2] Fixed iceberg sink can not handle uppercase fields Sep 23, 2024
@Hisoka-X Hisoka-X merged commit b7be0cb into apache:dev Sep 23, 2024
PeppaPage pushed a commit to PeppaPage/seatunnel that referenced this pull request Sep 23, 2024
@sunxiaojian @PeppaPage
[Fix][Connector-V2] Fixed iceberg sink can not handle uppercase fields (
a9b08f6 
apache#7660)
PeppaPage pushed a commit to PeppaPage/seatunnel that referenced this pull request Sep 23, 2024
@sunxiaojian @PeppaPage
[Fix][Connector-V2] Fixed iceberg sink can not handle uppercase fields (
b146e7c 
apache#7660)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hailin0 hailin0 hailin0 approved these changes

@Hisoka-X Hisoka-X Hisoka-X approved these changes

Assignees

No one assigned

Labels

connectors-v2 e2e iceberg

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunxiaojian @hailin0 @Hisoka-X